Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Certificate::from_pem_bundle() #2032

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

gibbz00
Copy link
Contributor

@gibbz00 gibbz00 commented Nov 11, 2023

Example where this could be used: https://doc.rust-lang.org/cargo/reference/config.html#httpcainfo

I chose not to use a path argument as requested in #421 for the sake of WASM support.

PR does not make an attempt at solving 1858, doing so would require the breaking API where certificates are passed directly to the corresponding certificate store.

Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This seems useful. I left some questions inline.

Cargo.toml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@seanmonstar seanmonstar merged commit ddf7f24 into seanmonstar:master Jan 29, 2024
31 checks passed
@gibbz00 gibbz00 deleted the cert_bundle branch January 31, 2024 20:30
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Feb 1, 2024
Bumps reqwest from 0.11.23 to 0.11.24.

Release notes
Sourced from reqwest's releases.

v0.11.24
What's Changed

Add Certificate::from_pem_bundle() to add a bundle.
Add http3_prior_knowledge() to blocking client builder.
Remove Sync bounds requirement for Body::wrap_stream().
Fix HTTP/2 to retry REFUSED_STREAM requests.
Fix instances of converting Url to Uri that could panic.

New Contributors

@​magurotuna made their first contribution in seanmonstar/reqwest#2081
@​michaelciraci made their first contribution in seanmonstar/reqwest#2102
@​basic-bgnr made their first contribution in seanmonstar/reqwest#2110
@​jgraef made their first contribution in seanmonstar/reqwest#2114
@​LucasPickering made their first contribution in seanmonstar/reqwest#2040
@​gibbz00 made their first contribution in seanmonstar/reqwest#2032

Full Changelog: seanmonstar/reqwest@v0.11.23...v0.11.24



Changelog
Sourced from reqwest's changelog.

v0.11.24

Add Certificate::from_pem_bundle() to add a bundle.
Add http3_prior_knowledge() to blocking client builder.
Remove Sync bounds requirement for Body::wrap_stream().
Fix HTTP/2 to retry REFUSED_STREAM requests.
Fix instances of converting Url to Uri that could panic.




Commits

c9b4b65 v0.11.24
ddf7f24 Add Certificate::from_pem_bundle() (#2032)
5d8443d fix panic when parsing invalid Url to Uri (#2040)
e3bf090 docs: explain TLS backend features better (#2117)
1bd939b update wasm-streams dependency (#2114)
87cdf12 doc: clarify Cookie API usage (#2111)
b3feff6 Add http3 feature to blocking client (#2110)
2332936 Update cookie crates (#2089)
ef2c8ee Upgrading env_logger dep (#2102)
4ab5fb0 Fix HTTP/2: retry requests rejected with REFUSED_STREAM (#2081)
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nutomic pushed a commit to Nutomic/reqwest that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants