Don't panic when parsing invalid Url to Uri #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
approved these changes
Jan 29, 2024
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Feb 1, 2024
Bumps reqwest from 0.11.23 to 0.11.24. Release notes Sourced from reqwest's releases. v0.11.24 What's Changed Add Certificate::from_pem_bundle() to add a bundle. Add http3_prior_knowledge() to blocking client builder. Remove Sync bounds requirement for Body::wrap_stream(). Fix HTTP/2 to retry REFUSED_STREAM requests. Fix instances of converting Url to Uri that could panic. New Contributors @magurotuna made their first contribution in seanmonstar/reqwest#2081 @michaelciraci made their first contribution in seanmonstar/reqwest#2102 @basic-bgnr made their first contribution in seanmonstar/reqwest#2110 @jgraef made their first contribution in seanmonstar/reqwest#2114 @LucasPickering made their first contribution in seanmonstar/reqwest#2040 @gibbz00 made their first contribution in seanmonstar/reqwest#2032 Full Changelog: seanmonstar/reqwest@v0.11.23...v0.11.24 Changelog Sourced from reqwest's changelog. v0.11.24 Add Certificate::from_pem_bundle() to add a bundle. Add http3_prior_knowledge() to blocking client builder. Remove Sync bounds requirement for Body::wrap_stream(). Fix HTTP/2 to retry REFUSED_STREAM requests. Fix instances of converting Url to Uri that could panic. Commits c9b4b65 v0.11.24 ddf7f24 Add Certificate::from_pem_bundle() (#2032) 5d8443d fix panic when parsing invalid Url to Uri (#2040) e3bf090 docs: explain TLS backend features better (#2117) 1bd939b update wasm-streams dependency (#2114) 87cdf12 doc: clarify Cookie API usage (#2111) b3feff6 Add http3 feature to blocking client (#2110) 2332936 Update cookie crates (#2089) ef2c8ee Upgrading env_logger dep (#2102) 4ab5fb0 Fix HTTP/2: retry requests rejected with REFUSED_STREAM (#2081) Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nutomic
pushed a commit
to Nutomic/reqwest
that referenced
this pull request
Nov 7, 2024
Instead propagate this parsing issue up to the calling function as a Result. See seanmonstar#668 Original PR: seanmonstar#1399 Co-authored-by: Matthias <matthias-endler@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #1399. The changes I made to the original PR:
expect_uritotry_uri. Now that it returns a result instead of panicking, this is more appropriatetry_urifunction with this one (it only had one usage)retry_errorCloses #668