-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file function to async_impl::multipart #2106
Add file function to async_impl::multipart #2106
Conversation
@NaokiM03 Are you still developing this? I would very much like this feature merged. |
No, this pull request is open, not draft. This means that the implementation I envisioned has already been done and is not under development. At the time I wanted this feature, but unfortunately I got no response. So I don't even know if this code is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to have let this drop! The code looks excellent to me, starting CI, and assuming all is well, I'd be happy to merge.
The test is down and I will try to fix it. |
Follow up on this pull request seanmonstar#2059
@seanmonstar Fixed an error that was occurring in CI. 350733f
No problem at all. I understand that you are busy and I appreciate your contribution to the Rust ecosystem because I like Rust. |
Related to #646
Add file function to
async_impl::multipart::{Form, Part}
.Notes
Since
From<File> for Body
was added in #1360, I decided to use thestream
function that uses it internally.This comment says
the backend did not support chunked requests
, butTransfer-Encoding: chunked
should be accepted forHTTP/1.1
.