Memberof trigger

[querdenker2k]

Created a memberOf option for item event triggers.
Discussed here: #22
When setting memberOf=true on a group-item the rule will fire for all direct group member events.

[seime]

@querdenker2k I've added an example of how to write trigger tests in #73 - WDYT? I'd love to get more tests in JRule as it is quite annoying to detect bugs only when my home automations quietly breaks after merging the latest code.

This PR is quite big so I expect something to break just by the sheer size of it.

[seime]

And by the way - great work! I've been waiting for this feature - it is the last missing nail in the DSL rule coffin for my setup :)

[querdenker2k]

@querdenker2k I've added an example of how to write trigger tests in #73 - WDYT? I'd love to get more tests in JRule as it is quite annoying to detect bugs only when my home automations quietly breaks after merging the latest code.

This PR is quite big so I expect something to break just by the sheer size of it.

yes, thats really anoying. i created my docker test project for this to test JRule with the real environment as a "blockbox". Maybe we could integrate this kind of testing as well.

[seaside1]

I'm getting some failed tests when merging with main.
@seime anything obvious?

[seaside1]

ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.037 s <<< FAILURE! - in org.openhab.binding.jrule.internal.triggers.itemchange.JRuleItemChangeTest
[ERROR] org.openhab.binding.jrule.internal.triggers.itemchange.JRuleItemChangeTest.testItemChange_from  Time elapsed: 0.76 s  <<< ERROR!
java.lang.NullPointerException
	at org.openhab.binding.jrule.internal.triggers.itemchange.JRuleItemChangeTest.testItemChange_from(JRuleItemChangeTest.java:49)

[ERROR] org.openhab.binding.jrule.internal.triggers.itemchange.JRuleItemChangeTest.testItemChange_no_from_to  Time elapsed: 0.022 s  <<< ERROR!
java.lang.NullPointerException
	at org.openhab.binding.jrule.internal.triggers.itemchange.JRuleItemChangeTest.testItemChange_no_from_to(JRuleItemChangeTest.java:40)

[ERROR] org.openhab.binding.jrule.internal.triggers.itemchange.JRuleItemChangeTest.testItemChange_from_to  Time elapsed: 0.013 s  <<< ERROR!
java.lang.NullPointerException
	at org.openhab.binding.jrule.internal.triggers.itemchange.JRuleItemChangeTest.testItemChange_from_to(JRuleItemChangeTest.java:67)

[seime]

@querdenker2k could you rebase and look at the tests?

[querdenker2k]

Yes will do it tomorrow

[seaside1]

Merging.