Initial tests for JRuleWhenItemChange triggers #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Very nice. |
|
Looks good. I'll merge as soon as I have tested. What are you guys opinion on debug level? For tests I prefer debug to be on, but it is easy to modify locally so not a big issue for me. |
|
I should probably update the jrule-user project as well as the documentation..... |
|
I prefer a higher log level with less output as default, but the ability to easily change to debug level whenever a testcase breaks and needs to be debugged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup in the testing department.
Added JRuleItemChange tests (at least a few). But code mainly serves as an example on how testcases could be written.
Plenty of room for improvements, but IMHO a step in the right direction.