This repository has been archived by the owner on Nov 23, 2019. It is now read-only.
Stop Generating MessageId #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2prateek
reviewed
Mar 7, 2019
| @@ -12,7 +12,6 @@ var integration = require('@segment/analytics.js-integration'); | |||
| var json = require('json3'); | |||
| var keys = require('@ndhoule/keys'); | |||
| var localstorage = require('yields-store'); | |||
| var md5 = require('spark-md5').hash; | |||
| var protocol = require('@segment/protocol'); | |||
There was a problem hiding this comment.
do we still need the uuid dependency?
There was a problem hiding this comment.
|
Code LGTM! I think we should update the version of a.js core as a dev here and add a test to verify it picks the messageId from whatever a.js provides. One more thing we can consider to reduce risk is to leave the generation logic as is, but make it check the root message first.
|
jlee9595
commented
Mar 8, 2019
| @@ -425,6 +410,13 @@ describe('Segment.io', function() { | |||
| assert(!object._metadata); | |||
| }); | |||
| }); | |||
|
|
|||
| it('should pick up messageId from AJS', function() { | |||
There was a problem hiding this comment.
@f2prateek Is this along the lines of what you were looking for?
f2prateek
approved these changes
Mar 8, 2019
|
(looks like some lint errors were flagged in CI, let's get those fixed before merging too) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accompanies segmentio/analytics.js-core#106