Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin known good combinations of segment deps #1

Merged
merged 4 commits into from
Feb 26, 2020

Conversation

wadejensen
Copy link
Owner

@wadejensen wadejensen commented Feb 24, 2020

Motivated by:

We got caught on the wrong side of an awkward semver for two libraries.
They moved where messageId is added and due to shitty use of semver on Segment’s part, and the fact that fivetran’s fork doesn’t pin exact dependency versions, we managed to get a combination of dependency versions which don’t send a message id.

Oh the irony…

See
segment-integrations/analytics.js-integration-segmentio#55
segmentio/analytics.js-core#106

~/repos/analytics.js wade-pin-known-good-segment-deps
❯ grep -r "messageId" analytics.js
analytics.js:  // generate and attach a messageId to msg
analytics.js:  msg.messageId = 'ajs-' + md5(json.stringify(msg) + uuid());

@wadejensen wadejensen force-pushed the wade-pin-known-good-segment-deps branch from 108173b to 1695da2 Compare February 24, 2020 13:36
@wadejensen wadejensen merged commit e7731a0 into master Feb 26, 2020
@wadejensen
Copy link
Owner Author

cc @ArthurBaudry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant