-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to implementations in other lanugages #49
Conversation
The Go library is the reference implementation, though not everyone uses Go. That's why it's useful to link to other implementations so people can use KSUID in the language of their choice.
Hi @tasn, are you aware if there is any KSUID implementation in Swift ? |
There is one on github, but with 0 stars, and haven't been developed in a while, so I didn't want to include it. |
Btw, @rbranson, would you mind taking a look at this? It's an easy review. |
Not sure if @rbranson has merge access to this repo anymore. I don't have strong feelings about this personally, although if we do add it, I don't personally feel that it warrants being before the description about what a KSUID is. @achille-roussel: what do you feel? |
Thanks for the feedback @abraithwaite! I can move it wherever, I just put it next to the "Install" so it's next to the Go one. Though I can also see a strong case for moving it elsewhere. Let me know where and I'll move it. |
Agree with @abraithwaite that we should probably put this further down in the README 👍 |
I moved it all the way to the bottom. Let me know if there's anything else you'd like me to change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Thanks for reviewing! |
When I created segmentio#49 I used the rust implementation that I thought was best based on looking at github/crates.io Though having actually used it now, it's very much lacking, so I ended up implementing a new one that has a saner internal representation, integrates with the rest of the Rust ecosystem, and tests a good chunk of the KSUID value space for correctness, as can be seen in: https://github.com/svix/rust-ksuid/blob/main/tests/test_kuids.txt
The Go library is the reference implementation, though not everyone uses Go.
That's why it's useful to link to other implementations so people can use KSUID
in the language of their choice.