README: replace the Rust implementation #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I created segmentio#49 I used the rust implementation that I thought was best based on looking at github/crates.io Though having actually used it now, it's very much lacking, so I ended up implementing a new one that has a saner internal representation, integrates with the rest of the Rust ecosystem, and tests a good chunk of the KSUID value space for correctness, as can be seen in: https://github.com/svix/rust-ksuid/blob/main/tests/test_kuids.txt
|
Nice work! I like the idea of making the timestamp precision configurable. Thanks for the sending the README update as well! |
|
Thanks! In retrospect, I should have probably gone for an even higher accuracy, so another extra byte or half a byte. Maybe in a future version. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I created #49 I used the rust implementation that I thought was best
based on looking at github/crates.io
Though having actually used it now, it's very much lacking, so I ended up
implementing a new one that has a saner internal representation, integrates
with the rest of the Rust ecosystem, and tests a good chunk of the KSUID
value space for correctness, as can be seen in:
https://github.com/svix/rust-ksuid/blob/main/tests/test_kuids.txt