Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the example 14 HTML #792

Closed
GeneTso opened this issue Oct 27, 2017 · 4 comments · Fixed by #866
Closed

Typo in the example 14 HTML #792

GeneTso opened this issue Oct 27, 2017 · 4 comments · Fixed by #866

Comments

@GeneTso
Copy link

GeneTso commented Oct 27, 2017

In the example 14 http://seiyria.com/bootstrap-slider/#example-14

<input id="ex14" type="text" data-slider-ticks="[0, 100, 200, 300, 400]" data-slider-ticks-snap-bounds="30" data-slider-ticks-labels='["$0", "$100", "$200", "$300", "$400"]' ticks_positions="[0, 30, 60, 70, 90, 100]" />

ticks_positions should be data-slider-ticks-positions

@seiyria
Copy link
Owner

seiyria commented Oct 27, 2017

Thanks

@rovolution
Copy link
Collaborator

@GeneTso we would love a PR that addresses this!

@jespirit
Copy link
Collaborator

@rovolution If I wanted to edit the API examples HTML page, do I need to submit a pull request on the gh-pages branch?

@rovolution
Copy link
Collaborator

rovolution commented Oct 23, 2018

@jespirit nope. need to make the change in the index.tpl file in the master branch and open a PR against our master branch

index.tpl is the template file that the gh-pages page is generated from.

seiyria added a commit that referenced this issue Oct 24, 2018
Fix Issue #792 - Typo in the example 14 HTML
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants