Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #792 - Typo in the example 14 HTML #866

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

jespirit
Copy link
Collaborator

@jespirit jespirit commented Oct 24, 2018

Pull Requests

Please accompany all pull requests with the following (where appropriate):

  • unit tests (we use Jasmine 2.x.x)
  • JSFiddle (or an equivalent such as CodePen, Plunker, etc) or screenshot/GIF with new feature or bug-fix
  • Link to original Github issue (if this is a bug-fix)
  • documentation updates to README file
  • examples within /tpl/index.tpl (for new options being added)
  • Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

Details

Fixes #792

The input data attribute should be data-slider-ticks-positions.

@seiyria seiyria merged commit baafe4b into seiyria:master Oct 24, 2018
@seiyria
Copy link
Owner

seiyria commented Oct 24, 2018

Hey! Thanks. Would you be interested in helping maintain the project? I saw you've been helping a lot in the issue tracker and if you'd be interested in helping with the project further I'd be happy to add you.

Would have reached out via email, but I didn't see one on your github profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in the example 14 HTML
2 participants