Fix Maximum number of Iterations Exceeded when no catalogs set for AT type #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
changed the title
xispa
approved these changes
Nov 14, 2023
xispa
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
On the bika api in function
get_catalogs_for, the variablecatalogsis expected to be a list that can be iterated on but it returnsNoneif we add a custom content type on our add-onCurrent behavior before PR
catalogs = archetype_tool.catalog_map.get(portal_type)isNoneandcatalogs = filter(None, map(lambda cid: get_tool(cid, None), catalogs))goes into
Maximum number of Iterations Exceedederror if catalogs is NoneDesired behavior after PR is merged
Catalogs should be an empty list if the tool(portal_type) is not found
catalogs = archetype_tool.catalog_map.get(portal_type) or []--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.