Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Maximum number of Iterations Exceeded when no catalogs set for AT type #2422

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Fix Maximum number of Iterations Exceeded when no catalogs set for AT type #2422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07952f7
Return list if catalog is not found instead of None
Lunga001 Nov 7, 2023
60e785c
Merge branch '2.x' into get-archetypes-catalogs
Lunga001 Nov 14, 2023
34c66c4
Changelog
Lunga001 Nov 14, 2023
d621400
Changelog
Lunga001 Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Changelog
2.5.0 (unreleased)
------------------

- #2422 Fix Maximum number of Iterations Exceeded when no catalogs set for AT type
- #2421 Fix hanging sampletype listing view in setup
- #2420 Fix page reload in multi results classic view
- #2419 Check permission when automatic sample reception is enabled
Expand Down
2 changes: 1 addition & 1 deletion src/bika/lims/api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1135,7 +1135,7 @@ def get_catalogs_for(brain_or_object, default=PORTAL_CATALOG):
# AT content type
# => Looup via archetype_tool
archetype_tool = get_tool("archetype_tool")
catalogs = archetype_tool.catalog_map.get(portal_type)
catalogs = archetype_tool.catalog_map.get(portal_type) or []
else:
# DX content type
# => resolve the `_catalogs` attribute from the class
Expand Down