Add legacyApp field for slack #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mokto
reviewed
Jul 22, 2020
| @@ -48,6 +48,9 @@ data: | |||
| slack.client-id: "{{ .Values.slack.clientId }}" | |||
| slack.client-secret: "{{ .Values.slack.clientSecret }}" | |||
| slack.verification-token: "{{ .Values.slack.verificationToken }}" | |||
| {{- if .Values.slack.legacyApp }} | |||
| slack.legacy-app: "{{ .Values.slack.legacyApp }}" | |||
There was a problem hiding this comment.
Thanks !
From what I see it should be a "python" boolean, not a string. Have you tried the behaviour on your instance?
There was a problem hiding this comment.
I haven't tried it in an instance. You're right, it should be a boolean here. I'll fix it.
There was a problem hiding this comment.
If you put # legacyApp: true in the values
and then
{{- if .Values.slack.legacyApp }}
slack.legacy-app: True
{{- else }}
slack.legacy-app: False
That would make it easy to use
There was a problem hiding this comment.
Thanks for the good suggestions. fixed it.
| @@ -192,6 +192,7 @@ slack: {} | |||
| # clientId: | |||
| # clientSecret: | |||
| # verificationToken: | |||
| # legacyApp: | |||
There was a problem hiding this comment.
Should we put another comment to reference this issue ?
getsentry/sentry#19446
There was a problem hiding this comment.
It's certainly better to be able to reference the issue.
|
Thanks! |
This was referenced Apr 12, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the integration with the Slack App to work, need to configure
slack.legacy-app.ref : getsentry/sentry#19446