Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacyApp field for slack #125

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Add legacyApp field for slack #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5946d97
add regacyApp field for slack
mrtc0 Jul 22, 2020
47985b9
use boolean
mrtc0 Jul 22, 2020
66153af
add comment for slack api deprecated issue reference
mrtc0 Jul 22, 2020
b8a741e
setting a value even if specify a true or false value
mrtc0 Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sentry/templates/configmap-sentry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ data:
slack.client-id: "{{ .Values.slack.clientId }}"
slack.client-secret: "{{ .Values.slack.clientSecret }}"
slack.verification-token: "{{ .Values.slack.verificationToken }}"
{{- if .Values.slack.legacyApp }}
slack.legacy-app: True
{{- else }}
slack.legacy-app: False
{{ end }}
{{ end }}

################
Expand Down
7 changes: 6 additions & 1 deletion sentry/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,11 @@ slack: {}
# clientId:
# clientSecret:
# verificationToken:
# # channels.* of Slack API is deprecated.
# # All new slack apps created after June 10th, 2020 will give error,
# # you need to specify `False` if you want to use the Slack App created after that.
# # ref : https://github.com/getsentry/sentry/pull/19446
# legacyApp:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put another comment to reference this issue ?
getsentry/sentry#19446

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's certainly better to be able to reference the issue.


ingress:
enabled: false
Expand Down Expand Up @@ -444,4 +449,4 @@ metrics:
# namespaceSelector:
# any: true
scrapeInterval: 30s
# honorLabels: true
# honorLabels: true