Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude patterns to avoid unnecessary logging #189

Closed
wants to merge 1 commit into from
Closed

Exclude patterns to avoid unnecessary logging #189

wants to merge 1 commit into from

Conversation

po5i
Copy link

@po5i po5i commented Feb 12, 2019

Addresses #182 #177

This PR attempts to add a migration option called exclude which is an array of patterns. If any file that is not a migration file and compiles any of these patterns, it will be ignored, otherwise the usual log will show up.

@po5i po5i changed the title Exclude patters to avoid unnecessary logging Exclude patterns to avoid unnecessary logging Feb 13, 2019
@po5i
Copy link
Author

po5i commented Feb 28, 2019

Hey @PascalPflaum would you mind to take a look or let me know who I should ping to in order to get this reviewed?

@sonicdoe
Copy link
Contributor

By the way, with #190 being merged (which removes the log line altogether), I don’t think these changes are necessary anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants