don't log non-migration files #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonSchick
approved these changes
Jun 12, 2019
|
@SimonSchick @PascalPflaum is there a timeline for this to be released? |
|
@mmkal I do not have publishing access. |
Closed
mmkal
added a commit
to mmkal/pgkit
that referenced
this pull request
Apr 7, 2020
this includes a logging fix: sequelize/umzug#190
mmkal
added a commit
to mmkal/pgkit
that referenced
this pull request
Apr 7, 2020
* fix(logs): use umzug 2.3.0 this includes a logging fix: sequelize/umzug#190 * chore: update lockfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PascalPflaum very minor thing, but it's been bugging me for a while. There's not much value in logging when a filename isn't matched by
patternsince that's the whole reasonpatternexists. It can end up a little noisy on stdout.