-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ethereum test failure #441
Comments
The CI consistently fails. It uses the nightly foundry which updated k256 in foundry-rs/foundry#6327. k256 changed their ecrecover functionality, as documented in RustCrypto/elliptic-curves#988, which borked revm. foundry uses revm. Not our fault. |
foundry-rs/foundry#6358 will close this. |
We got affected by this due to #116. It seems while foundry does not have stable versions to pin to, you can pin to nightly versions (I didn't realize you could pin to "nightly-x" instead of just "nightly") per foundry-rs/foundry-toolchain#35. Accordingly, we can resolve this (and #116) on our end. |
Fixes serai-dex#116 and serai-dex#441.
I'm really unsure why this failed.
The tests passed in 30a77d8 and failed in 25c02c1.
The only
Cargo.lock
changes bumpeded25519-dalek
,zeroize
, andrustls
in db49a63 (none should have impact here).crypto
andcoins
were not further edited.common
only had serai-db edited.That appears to be far too many zeroes to be valid, if that is the calldata. That'd suggest a bug re: zeroization, yet ethereum-serai doesn't pull in zeroize (at least, not directly).
The tests pass locally. I'll rerun them on the CI now.
The text was updated successfully, but these errors were encountered: