Revert k256 bump #6358
Merged
Revert k256 bump #6358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This k256 version breaks revm, as documented in RustCrypto/elliptic-curves#988, which breaks foundry. While I would instead wait to bump revm, foundry nightly (the only supported version per the provided GH action) is broken and I'd rather correct it ASAP.
kayabaNerve
requested review from
DaniPopes,
Evalir and
mattsse
as code owners
|
You'll want to lock it in a manifest otherwise anyone can bump it without even meaning to. |
|
Done |
DaniPopes
approved these changes
Nov 20, 2023
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This k256 version breaks revm, as documented in
RustCrypto/elliptic-curves#988, which breaks foundry.
While I would instead wait to bump revm, foundry nightly (the only supported version per the provided GH action) is broken and I'd rather correct it ASAP.
Motivation
Foundry nightly is broken.
Solution
Revert the k256 bump until revm supports k256 0.13.2.