-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple value keys #157
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address my notes
index.js
Outdated
@@ -430,6 +430,11 @@ function make_bloodhound(dataset) { | |||
var engine; | |||
|
|||
if (need_bloodhound) { | |||
// Supports multiple fields passed, deliniated by spaces | |||
if (dataset.valueKey.indexOf(" ") !== -1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider to use comma as delimiter
index.js
Outdated
@@ -430,6 +430,11 @@ function make_bloodhound(dataset) { | |||
var engine; | |||
|
|||
if (need_bloodhound) { | |||
// Supports multiple fields passed, deliniated by spaces | |||
if (dataset.valueKey.indexOf(" ") !== -1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also lets avoid mutation of input argument performing this initialization in calling code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks, was just a quick initial thought as I'm working it into my own project. I'll update, and use your comma suggestion as I do.
Minor change to the docs to log the object instead of assuming it is a string
Simply splits the passed string for value keys on space deliniation to pass as bloodhound.tokenizer parameter.