Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple value keys #157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for multiple value keys #157

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44050a4
Add support for multiple value keys
robertdavid010 Apr 7, 2017
4d72e12
Add passing of specific key field
robertdavid010 Apr 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,11 @@ function make_bloodhound(dataset) {
var engine;

if (need_bloodhound) {
// Supports multiple fields passed, deliniated by spaces
if (dataset.valueKey.indexOf(" ") !== -1) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider to use comma as delimiter

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also lets avoid mutation of input argument performing this initialization in calling code

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, was just a quick initial thought as I'm working it into my own project. I'll update, and use your comma suggestion as I do.

dataset.valueKey = dataset.valueKey.split(" ");
};

var options = $.extend({}, dataset, {
// TODO support custom tokenizers
datumTokenizer: Bloodhound.tokenizers.obj.whitespace(dataset.valueKey),
Expand Down