Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent prefix for system events and metrics #425

Closed
mthenw opened this issue May 14, 2018 · 1 comment · Fixed by #486
Closed

Consistent prefix for system events and metrics #425

mthenw opened this issue May 14, 2018 · 1 comment · Fixed by #486

Comments

@mthenw
Copy link
Contributor

mthenw commented May 14, 2018

Right now we use gateway. prefix in both system events and metrics. Especially for metrics we need to be more specific and gateway sounds like a bit too generic. My proposition is to change the prefix to eventgateway or event-gateway.

Another option is to use different prefix for system event and different for metrics. For metrics it's probably OK to prefix them with eventgateway.

For system events, as they are CloudEvents we could probably do something like com.serverless.eventgateway.

@austencollins
Copy link
Member

Follow CloudEvents conventions whenever possible.

Also, a useful reference: https://stripe.com/docs/api#event_types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants