Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent prefix for system events and metrics. Closes #425 #486

Merged
merged 3 commits into from
Jul 24, 2018
Merged

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jul 24, 2018

What did you implement:

Closes #425

How did you implement it:

All metrics and system events are not prefixed with eventgateway prefix. gateway was too ambiguous.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: YES

@mthenw mthenw requested a review from sebito91 July 24, 2018 12:12
@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #486 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #486   +/-   ##
=======================================
  Coverage   70.77%   70.77%           
=======================================
  Files          37       37           
  Lines        2190     2190           
=======================================
  Hits         1550     1550           
  Misses        576      576           
  Partials       64       64
Impacted Files Coverage Δ
httpapi/metrics.go 100% <ø> (ø) ⬆️
router/metrics.go 35.29% <ø> (ø) ⬆️
event/event.go 78.12% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e58739...ae499ed. Read the comment docs.

@mthenw
Copy link
Contributor Author

mthenw commented Jul 24, 2018

This coverage is somehow broken, not sure why.

Copy link
Contributor

@sebito91 sebito91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebito91
Copy link
Contributor

lgtm2

@mthenw mthenw merged commit 66f4c60 into master Jul 24, 2018
@mthenw mthenw deleted the prefix branch July 24, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent prefix for system events and metrics
2 participants