Add Direct Secret Reference extension #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
scothis
reviewed
Sep 21, 2020
scothis
approved these changes
Sep 21, 2020
baijum
force-pushed
the
direct-secret
branch
2 times, most recently
from
b092b72
to
37c9037
Compare
Direct Secret Reference extension allows Service Binding resource with the service directly pointing to a secret resource. This address the "Native Bindings" issue servicebinding#92 Co-authored-by: Scott Andrews <scott@andrews.me> Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
baijum
force-pushed
the
direct-secret
branch
from
37c9037
to
443c927
Compare
|
If anybody is interested in trying out this spec extension, I have a draft implementation over at vmware-tanzu/servicebinding#64 |
arthurdm
reviewed
Sep 29, 2020
Co-authored-by: Arthur De Magalhaes <arthurdm@ca.ibm.com>
Thanks! I have committed your change. |
nebhale
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct Secret Reference extension allows Service Binding resource
with the service directly pointing to a secret resource.
This address the "Native Bindings" issue #92
Signed-off-by: Baiju Muthukadan baiju.m.mail@gmail.com