Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow binding directly from secrets #64

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Allow binding directly from secrets #64

merged 3 commits into from
Oct 7, 2020

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Sep 22, 2020

@scothis
Allow binding directly from secrets
3635a12 
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@vmwclabot vmwclabot added the cla-not-required CLA not required label Sep 22, 2020
@codecov
Copy link

codecov bot commented Sep 22, 2020 •
edited
Loading

Codecov Report

Merging #64 into main will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   91.05%   91.09%   +0.03%     
==========================================
  Files          18       18              
  Lines         548      550       +2     
==========================================
+ Hits          499      501       +2     
  Misses         28       28              
  Partials       21       21
Impacted Files Coverage Δ
pkg/resolver/serviceable_resolver.go 92.00% <100.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e15451a...00e4426. Read the comment docs.

@scothis scothis mentioned this pull request Sep 22, 2020
Merged
@scothis
Update samples to consume secrets directly
00e4426 
This makes the sample portable to other implementations. Also adding a
new sample to show using a ProvisionedService.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@scothis scothis marked this pull request as ready for review October 7, 2020 22:42
@scothis
Copy link
Contributor Author

scothis commented Oct 7, 2020

The upstream spec extension hasn't merge (yet), but this change is good even if it is non-standard

@scothis scothis merged commit 3ff6f1c into vmware-tanzu:main Oct 7, 2020
@scothis scothis deleted the direct-secrets branch October 7, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-not-required CLA not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scothis @vmwclabot