Handle all `white-space` values when intrinsically sizing an IFC #33343

Loirooriol · 2024-09-06T08:58:50Z

There were various cases like text-wrap-mode: nowrap and
white-space-collapse: break-spaces that weren't handled well.

Fixes #33335

flexbox_flex-formatting-interop.html fails now because we don't support
table-layout: fixed.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Wrong min-content size for white-space: nowrap #33335
There are tests for these change

github-actions · 2024-09-06T08:59:07Z

🔨 Triggering try run (#10735525011) for Linux WPT

github-actions · 2024-09-06T09:37:32Z

Test results for linux-wpt-layout-2020 from try job (#10735525011):

Flaky unexpected result (23)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected PASS] /css/compositing/mix-blend-mode/mix-blend-mode-video-sibling.html (#32849)
FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- PASS [expected FAIL] subtest: listeners are called correct number of times
OK /css/cssom-view/MediaQueryList-change-event-matches-value.html (#27973)
- FAIL [expected PASS] subtest: MediaQueryList.changed is correct for all lists in the document even during a change event handler
```
assert_equals: Should've fired the change event in both MediaQueryLists expected 2 but got 0
```
OK /css/cssom-view/MediaQueryList-extends-EventTarget.html (#25269)
- FAIL [expected PASS] subtest: onchange adds listener
```
promise_test: Unhandled rejection with value: object "TypeError: _event is undefined"
```
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-origin destination, no attributes
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html (#28765)
- TIMEOUT [expected FAIL] subtest: Replace before load, triggered by submitButton.click()
```
Test timed out
```
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
- PASS [expected FAIL] subtest: opener of discarded auxiliary browsing context
ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html (#32745)
OK /html/semantics/embedded-content/media-elements/media_fragment_seek.html (#24114)
- FAIL [expected PASS] subtest: Video should seek to time specified in media fragment syntax
```
assert_equals: expected 4 but got 0
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- FAIL [expected PASS] subtest: DOMParser
```
assert_unreached: got unexpected load event Reached unreachable code
```
- FAIL [expected PASS] subtest: createHTMLDocument
```
assert_unreached: got unexpected error event Reached unreachable code
```
- FAIL [expected PASS] subtest: <template>
```
assert_unreached: got unexpected error event Reached unreachable code
```
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in name (formdata event)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: backslash in filename (formdata event)
CRASH [expected OK] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730)
OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
- FAIL [expected PASS] subtest: document.write in an imported module
```
assert_true: onload must be called expected true got false
```
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.
OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)
OK /xhr/open-url-multi-window-5.htm (#23360)
- FAIL [expected PASS] subtest: XMLHttpRequest: open() resolving URLs (multi-Window; 5)
```
assert_throws_dom: function "function() {client.open("GET", "...") }" did not throw
```

Stable unexpected results that are known to be intermittent (6)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- PASS [expected TIMEOUT] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args.html (#32745)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
OK /html/webappapis/dynamic-markup-insertion/document-write/module-delayed.html (#27659)
- PASS [expected FAIL] subtest: async document.write in a module

Stable unexpected results (4)

FAIL [expected PASS] /css/css-flexbox/flexbox_flex-formatting-interop.html
OK /css/css-tables/tentative/table-quirks.html
- PASS [expected FAIL] subtest: table 3
PASS [expected FAIL] /css/css-text/white-space/white-space-intrinsic-size-002.html
PASS [expected FAIL] /css/css-ui/text-overflow-025.html

github-actions · 2024-09-06T09:37:43Z

⚠️ Try run (#10735525011) failed.

servo-wpt-sync · 2024-09-09T11:01:02Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#48041) with upstreamable changes.

github-actions · 2024-09-09T11:08:06Z

🔨 Triggering try run (#10771957679) for Linux WPT

servo-wpt-sync · 2024-09-09T11:08:35Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#48041) title and body.

servo-wpt-sync · 2024-09-09T11:09:54Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#48041).

github-actions · 2024-09-09T11:31:44Z

Test results for linux-wpt-layout-2020 from try job (#10771957679):

Flaky unexpected result (13)

CRASH [expected PASS] /_webgl/conformance/glsl/bugs/nested-functions-should-not-crash.html (#30680)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
FAIL [expected PASS] /css/css-values/vh_not_refreshing_on_chrome.html (#23385, #15570)
TIMEOUT [expected PASS] /encoding/streams/stringification-crash.html
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
- FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "A" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿ" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿĀ" but got ""
```
- FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked
```
assert_equals: expected "😍" but got ""
```
- FAIL [expected PASS] subtest: DE0D 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "\ufffdA" but got ""
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
```
assert_equals: expected "" but got "#fragment"
```
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: 0x00 in value (normal form)
- PASS [expected FAIL] subtest: text/plain: \r\n in value (normal form)
- PASS [expected FAIL] subtest: text/plain: single quote in name (formdata event)
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
- FAIL [expected PASS] subtest: document.write in an imported module
```
assert_true: onload must be called expected true got false
```

Stable unexpected results that are known to be intermittent (18)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- PASS [expected FAIL] subtest: listeners are called correct number of times
- FAIL [expected PASS] subtest: listeners are called in order their MQLs were created
```
assert_array_equals: lengths differ, expected array ["mql1", "mql2"] length 2, got [] length 0
```
OK /css/cssom-view/MediaQueryList-extends-EventTarget-interop.html (#25285)
- PASS [expected FAIL] subtest: capturing event listener fires before non-capturing listener at target
OK /css/cssom-view/MediaQueryListEvent.html (#25275)
- PASS [expected FAIL] subtest: argument of addListener
- FAIL [expected PASS] subtest: argument of onchange
```
assert_true: expected true got false
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html (#32745)
TIMEOUT [expected ERROR] /html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args.html (#32745)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task
```
Test timed out
```
OK /html/webappapis/update-rendering/child-document-raf-order.html (#33028)
- PASS [expected FAIL] subtest: Ordering of steps in "Update the Rendering" - child document requestAnimationFrame order
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
```
assert_true: Reload domContentLoadedEventStart &gt; Original domContentLoadedEventStart expected true got false
```
- FAIL [expected PASS] subtest: Reload fetchStart > Original fetchStart
```
assert_true: Reload fetchStart &gt; Original fetchStart expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```
OK [expected TIMEOUT] /resource-timing/nested-context-navigations-iframe.html (#24311)
- PASS [expected NOTRUN] subtest: Test that iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that crossorigin iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that cross-site iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that iframe refreshes are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that cross-site iframe refreshes are not observable by the parent
ERROR [expected OK] /webxr/render_state_update.https.html (#27535)
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)

github-actions · 2024-09-09T11:31:54Z

✨ Try run (#10771957679) succeeded.

mrobinson

Nice!

components/fonts/glyph.rs

components/layout_2020/flow/inline/mod.rs

components/layout_2020/flow/inline/text_run.rs

tests/wpt/tests/css/css-text/white-space/break-spaces-with-word-break-001.html

servo-wpt-sync · 2024-09-11T13:00:37Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#48041).

There were various cases like `text-wrap-mode: nowrap` and `white-space-collapse: break-spaces` that weren't handled well. Fixes servo#33335 flexbox_flex-formatting-interop.html fails now because we don't support `table-layout: fixed`. Signed-off-by: Oriol Brufau <obrufau@igalia.com>

Loirooriol · 2024-09-11T17:07:40Z

There was a windows-specific unit test that needed to pass the new parameter.

servo-wpt-sync · 2024-09-11T17:09:07Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#48041).

Loirooriol added A-layout/inline A-layout/2020 https://github.com/servo/servo/wiki/Layout-2020 T-linux-wpt-2020 Do a try run of the WPT labels Sep 6, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Sep 6, 2024

Loirooriol force-pushed the intrinsic-sizing-white-space branch from bbcfd04 to b2073ed Compare September 9, 2024 10:58

servo-wpt-sync mentioned this pull request Sep 9, 2024

Handle all white-space values when intrinsically sizing an IFC web-platform-tests/wpt#48041

Merged

Loirooriol force-pushed the intrinsic-sizing-white-space branch from b2073ed to dea7288 Compare September 9, 2024 11:07

Loirooriol added the T-linux-wpt-2020 Do a try run of the WPT label Sep 9, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Sep 9, 2024

Loirooriol marked this pull request as ready for review September 9, 2024 11:09

Loirooriol requested a review from mrobinson September 9, 2024 11:09

mrobinson approved these changes Sep 10, 2024

View reviewed changes

Loirooriol force-pushed the intrinsic-sizing-white-space branch from dea7288 to 5ae25a5 Compare September 11, 2024 12:58

Loirooriol enabled auto-merge September 11, 2024 12:59

Loirooriol added this pull request to the merge queue Sep 11, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024

Loirooriol force-pushed the intrinsic-sizing-white-space branch from 5ae25a5 to 7659724 Compare September 11, 2024 17:06

Loirooriol enabled auto-merge September 11, 2024 17:07

Loirooriol added this pull request to the merge queue Sep 11, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024

Loirooriol added this pull request to the merge queue Sep 11, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024

Loirooriol added this pull request to the merge queue Sep 11, 2024

Merged via the queue into servo:main with commit d9be9d6 Sep 12, 2024
14 checks passed

Loirooriol deleted the intrinsic-sizing-white-space branch September 12, 2024 00:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle all `white-space` values when intrinsically sizing an IFC #33343

Handle all `white-space` values when intrinsically sizing an IFC #33343

Loirooriol commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

servo-wpt-sync commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

servo-wpt-sync commented Sep 9, 2024

servo-wpt-sync commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

mrobinson left a comment

servo-wpt-sync commented Sep 11, 2024

Loirooriol commented Sep 11, 2024

servo-wpt-sync commented Sep 11, 2024

Handle all white-space values when intrinsically sizing an IFC #33343

Handle all white-space values when intrinsically sizing an IFC #33343

Conversation

Loirooriol commented Sep 6, 2024 • edited Loading

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

servo-wpt-sync commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

servo-wpt-sync commented Sep 9, 2024

servo-wpt-sync commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

mrobinson left a comment

Choose a reason for hiding this comment

servo-wpt-sync commented Sep 11, 2024

Loirooriol commented Sep 11, 2024

servo-wpt-sync commented Sep 11, 2024

Handle all `white-space` values when intrinsically sizing an IFC #33343

Handle all `white-space` values when intrinsically sizing an IFC #33343

Loirooriol commented Sep 6, 2024 •

edited

Loading