Handle all white-space values when intrinsically sizing an IFC
#48041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wpt-pr-bot
approved these changes
Sep 9, 2024
servo-wpt-sync
force-pushed
the
servo_export_33343
branch
2 times, most recently
from
44497eb
to
0a35113
Compare
There were various cases like `text-wrap-mode: nowrap` and `white-space-collapse: break-spaces` that weren't handled well. Fixes web-platform-tests#33335 flexbox_flex-formatting-interop.html fails now because we don't support `table-layout: fixed`. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
servo-wpt-sync
force-pushed
the
servo_export_33343
branch
from
0a35113
to
56e2a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were various cases like
text-wrap-mode: nowrapandwhite-space-collapse: break-spacesthat weren't handled well.Fixes #33335
flexbox_flex-formatting-interop.html fails now because we don't support
table-layout: fixed.Reviewed in servo/servo#33343