[BUG] parse_variant() may inadvertently move lvalues
#589
Comments
TedLyngmo
added a commit
to TedLyngmo/redis-plus-plus
that referenced
this issue
Sep 10, 2024
reply.h: std::move was used where std::forward should be used Fixes sewenew#589 Also made move semantics noexcept in connection_pool Signed-off-by: Ted Lyngmo <ted@lyncon.se>
TedLyngmo
added a commit
to TedLyngmo/redis-plus-plus
that referenced
this issue
Sep 12, 2024
reply.h: std::move was used where std::forward should be used Fixes sewenew#589 Signed-off-by: Ted Lyngmo <ted@lyncon.se>
sewenew
pushed a commit
that referenced
this issue
Sep 13, 2024
reply.h: std::move was used where std::forward should be used Fixes #589 Signed-off-by: Ted Lyngmo <ted@lyncon.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
reply.h:312:36: forwarding reference passed to std::move()
To Reproduce
Make sure a non-
constlvalue is processed. Theconstructor of the
Variantwill be used which will forward that to the constructor of the matching type.Expected behavior
Expecting non-temporaries to be copied instead of moved. That is, use
std::forwardinstead ofstd::moveThe text was updated successfully, but these errors were encountered: