Fix a static analysis warning #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure to build on Windows seems unrelated to this patch: |
sewenew
reviewed
Sep 12, 2024
|
Thanks for your contributing! Could you revert the noexcept change, and I'll merge your PR. Thanks again! |
Yes. The Windows build failure has nothing to do with your PR. |
reply.h: std::move was used where std::forward should be used Fixes sewenew#589 Signed-off-by: Ted Lyngmo <ted@lyncon.se>
TedLyngmo
force-pushed
the
fix_static_analysis_warnings
branch
from
99a8cbb
to
1317ed9
Compare
TedLyngmo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reply.h:std::movewas used wherestd::forwardshould be usedFixes #589