Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"macos-aarch64" package from the release works for Intel chip but not for M3 chip. #4812

Closed
jkwak-work opened this issue Aug 9, 2024 · 2 comments · Fixed by #4847
Closed

"macos-aarch64" package from the release works for Intel chip but not for M3 chip. #4812

jkwak-work opened this issue Aug 9, 2024 · 2 comments · Fixed by #4847
Assignees
@jkwak-work
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang

Comments

@jkwak-work
Copy link
Collaborator

Problem description
When I download the binary release package for macos-aarch64, slang-test passes on all tests even when they should fail.
This was due to the fact that slang-llvm was not actually working; and tests are reported passing incorrectly.

It turned out that the release binary works fine for MacBook Pro 2019 that uses an Intel chip.
But it doesn't work when the chip is M3.

A workaround for this is to locally rebuild slang-llvm when the hardware uses M3 chip.

The issue appears to be limited only to slang-llvm binary; not slangc or other binaries in the release package.

Goal
Because the package name has "aarch64" suffix, the binary package should run on M3 chip.
@jkwak-work jkwak-work self-assigned this Aug 9, 2024
@jkwak-work jkwak-work added goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang goal:forward looking Feature needed at a later date, not connected to a specific use case. and removed goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang goal:forward looking Feature needed at a later date, not connected to a specific use case. labels Aug 9, 2024
@jkwak-work
Copy link
Collaborator Author

@expipiplus1 , do you have any guesses of why this is happening?

jkwak-work added a commit to jkwak-work/slang that referenced this issue Aug 9, 2024
@jkwak-work
Update build steps for MacOS
47f68c9 
This commit adds a quick build step for MacOS on CONTRIBUTION.md.

It is unclear what are the conditions that slang-llvm needs to be
rebuilt locally. An issue is filed for it, shader-slang#4812
jkwak-work added a commit to jkwak-work/slang that referenced this issue Aug 9, 2024
@jkwak-work
Update build steps for MacOS
8e332da 
This commit adds a quick build step for MacOS on CONTRIBUTION.md.

It is unclear what are the conditions that slang-llvm needs to be
rebuilt locally. An issue is filed for it, shader-slang#4812
jkwak-work added a commit to jkwak-work/slang that referenced this issue Aug 9, 2024
@jkwak-work
Update build steps for MacOS
32a2b48 
This commit adds a quick build step for MacOS on CONTRIBUTION.md.

It is unclear what are the conditions that slang-llvm needs to be
rebuilt locally. An issue is filed for it, shader-slang#4812
@jkwak-work jkwak-work mentioned this issue Aug 9, 2024
Merged
jkwak-work added a commit to jkwak-work/slang that referenced this issue Aug 9, 2024
@jkwak-work
Update build steps for MacOS
df2d9be 
This commit adds a quick build step for MacOS on CONTRIBUTION.md.

It is unclear what are the conditions that slang-llvm needs to be
rebuilt locally. An issue is filed for it, shader-slang#4812
csyonghe pushed a commit that referenced this issue Aug 13, 2024
@jkwak-work
Update build steps for MacOS (#4813)
bbef25c 
This commit adds a quick build step for MacOS on CONTRIBUTION.md.

It is unclear what are the conditions that slang-llvm needs to be
rebuilt locally. An issue is filed for it, #4812
expipiplus1 added a commit to expipiplus1/slang that referenced this issue Aug 14, 2024
@expipiplus1
Fetch slang-llvm.so from correct release
92f7221 
Closes shader-slang#4648
Should close shader-slang#4812
@expipiplus1 expipiplus1 mentioned this issue Aug 14, 2024
Merged
@expipiplus1
Copy link
Collaborator

This should be fixed by #4847 If you could give this a test please :)

expipiplus1 added a commit to expipiplus1/slang that referenced this issue Aug 21, 2024
@expipiplus1 @csyonghe
Fetch slang-llvm.so from correct release (shader-slang#4847)
cf7d59a 
* Fetch slang-llvm.so from correct release

Closes shader-slang#4648
Should close shader-slang#4812

* Update docs

* Correct documentation on cmake option

* Neaten cmake script

* Fix fetching on windows

---------

Co-authored-by: Yong He <yonghe@outlook.com>
expipiplus1 added a commit that referenced this issue Aug 21, 2024
@expipiplus1 @csyonghe
Dont require llvm for building generators (#4895)
f503a0b 
* Dont require llvm for building generators

* Fetch slang-llvm.so from correct release (#4847)

* Fetch slang-llvm.so from correct release

Closes #4648
Should close #4812

* Update docs

* Correct documentation on cmake option

* Neaten cmake script

* Fix fetching on windows

---------

Co-authored-by: Yong He <yonghe@outlook.com>

* Be a bit more careful dealing with release list fetching failure

* clarify error messages

---------

Co-authored-by: Yong He <yonghe@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkwak-work jkwak-work

Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fetch slang-llvm.so from correct release expipiplus1/slang
2 participants
@expipiplus1 @jkwak-work