Make CTS nightly run reporting status to our slack channel. #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizhangNV
force-pushed
the
kai/cts-report
branch
from
c4b659b
to
66f1119
Compare
The CTS nightly stops report error because of `continue-on-error` is set to true. Remove that field such that it will fail the job. Add slack notification about the CTS status, this will report the status of CTS nightly result to our slack dev channel.
kaizhangNV
force-pushed
the
kai/cts-report
branch
from
66f1119
to
281fc1d
Compare
jkwak-work
approved these changes
May 23, 2024
| @@ -12,7 +12,6 @@ jobs: | |||
| build: | |||
| runs-on: [Windows, self-hosted] | |||
| timeout-minutes: 180 | |||
| continue-on-error: true | |||
There was a problem hiding this comment.
Is the default false?
Can we just have it explicitly set to false?
There was a problem hiding this comment.
Yea, it's default to false.
There was a problem hiding this comment.
But it's doesn't matter now, because I set
- name: result notification
id: slack-notify
if : always()
which will make sure this "slack-notify" keep running no matter CTS fail or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.