Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metal to user-guide/09-targets.md #4703

Conversation

jkwak-work
Copy link
Collaborator

@jkwak-work jkwak-work commented Jul 22, 2024

Related to an issue #4262

The description of "Parameter passing" part for Metal is related to PR #4022.

@jkwak-work jkwak-work requested a review from csyonghe July 22, 2024 15:52
@jkwak-work jkwak-work force-pushed the doc/add_metal_to_user_guide_09_targets branch from eb21fdd to f3f6152 Compare July 22, 2024 15:56
Partially resolves shader-slang#4262

The description of "Parameter passing" part for Metal is related to PR shader-slang#4022
@jkwak-work jkwak-work force-pushed the doc/add_metal_to_user_guide_09_targets branch from f3f6152 to 1cbceaa Compare July 22, 2024 15:58
@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Jul 22, 2024
@jkwak-work jkwak-work self-assigned this Jul 22, 2024
@csyonghe
Copy link
Collaborator

You need to update the table of contents by running docs/build-toc.ps1

@ArielG-NV
Copy link
Contributor

ArielG-NV commented Jul 22, 2024

it seems that adding "Partially resolves #4262" to the PR description may cause #4262 to close automatically upon this PR being merged (this likely should be changed)

@jkwak-work
Copy link
Collaborator Author

I addressed both comments above.

@jkwak-work jkwak-work merged commit 15f091a into shader-slang:master Jul 23, 2024
11 checks passed
@jkwak-work jkwak-work deleted the doc/add_metal_to_user_guide_09_targets branch July 23, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants