Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video progress events #2656

Closed
joeyparrish opened this issue Jun 16, 2020 · 0 comments · Fixed by #5850
Closed

Video progress events #2656

joeyparrish opened this issue Jun 16, 2020 · 0 comments · Fixed by #5850
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v4.6

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes

Is your feature request related to a problem? Please describe.

Ad SDKs tend to have events for ad progress (quartiles, etc). We've been asked by a partner to add something similar for main video content.

Describe the solution you'd like

shaka.Player could emit video progress events. IMA SDK's ad progress events are STARTED, FIRST_QUARTILE, MIDPOINT, THIRD_QUARTILE, and COMPLETE. Though this could be done already by applications using timeupdate events on the video, we could provide these or similar events for convenience.

Describe alternatives you've considered

Let apps use timeupdate and ended events to handle it themselves.

Additional context

IMA ad event references:
@joeyparrish joeyparrish added the type: enhancement New feature or request label Jun 16, 2020
@shaka-bot shaka-bot added this to the Backlog milestone Jun 16, 2020
@joeyparrish joeyparrish added the priority: P2 Smaller impact or easy workaround label Sep 29, 2021
@avelad avelad mentioned this issue Nov 3, 2023
Merged
@avelad avelad modified the milestones: Backlog, v4.6 Nov 3, 2023
avelad added a commit that referenced this issue Nov 7, 2023
@avelad
feat: Add video progress events (#5850)
c3beee6 
Closes #2656
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
feat: Add video progress events (shaka-project#5850)
397ca32 
Closes shaka-project#2656
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 6, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.6
Development

Successfully merging a pull request may close this issue.

feat: Add video progress events avelad/shaka-player
3 participants
@joeyparrish @avelad @shaka-bot