feat: Add video progress events #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
avelad
force-pushed
the
video-progress-events
branch
from
bed2e68 to
185ddf1
Compare
|
Incremental code coverage: 96.72% |
theodab
requested changes
Nov 7, 2023
| } | ||
| if (hasNewCompletionPercent) { | ||
| let event; | ||
| if (this.completionPercent_ == 0) { |
There was a problem hiding this comment.
Hm.
According to MDN, at the slowest, we can expect around 4 timeupdate events per second.
For a very short clip (<25 seconds), if the events are happening at the slowest expected rate, there is the possibility that the completion percent might go up by more than 1 between two events, which could cause us to skip over a quartile event...
I think this would be most likely to happen with the started event, since all that would really need to happen would be for the first timeupdate event to happen at 0.51% progress (so it gets rounded up to 1%).
I don't know how realistic that combination of factors would be in practice, though.
theodab
approved these changes
Nov 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2656