fix(text): Fix cue region rendering in UI #4412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both TTML and VTT regions should be thought of as separate elements from the cue structures they contain. To this end, the UI text displayer now creates separate region elements to represent CueRegion objects, and the Cues attached to them nest inside those region elements in the DOM. Closes shaka-project#4381
|
Incremental code coverage: 98.53% |
theodab
requested changes
Aug 16, 2022
theodab
approved these changes
Aug 16, 2022
joeyparrish
added a commit
that referenced
this pull request
Aug 16, 2022
Both TTML and VTT regions should be thought of as separate elements from the cue structures they contain. To this end, the UI text displayer now creates separate region elements to represent CueRegion objects, and the Cues attached to them nest inside those region elements in the DOM. Closes #4381
joeyparrish
added a commit
that referenced
this pull request
Aug 17, 2022
Both TTML and VTT regions should be thought of as separate elements from the cue structures they contain. To this end, the UI text displayer now creates separate region elements to represent CueRegion objects, and the Cues attached to them nest inside those region elements in the DOM. Closes #4381
joeyparrish
added a commit
that referenced
this pull request
Aug 17, 2022
Both TTML and VTT regions should be thought of as separate elements from the cue structures they contain. To this end, the UI text displayer now creates separate region elements to represent CueRegion objects, and the Cues attached to them nest inside those region elements in the DOM. Closes #4381
joeyparrish
added a commit
that referenced
this pull request
Aug 17, 2022
Both TTML and VTT regions should be thought of as separate elements from the cue structures they contain. To this end, the UI text displayer now creates separate region elements to represent CueRegion objects, and the Cues attached to them nest inside those region elements in the DOM. Closes #4381
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
Aug 29, 2022
Without an explicit size, some platforms render bitmap-based cues as 0x0. This effect was seen in Chrome on Mac in particular. This started with PR shaka-project#4412, where we factored out regions into their own element. The TTML spec says that background images should fill their associated region, so this fixes the issue by making the div explicitly the size of its parent element (100% x 100%).
joeyparrish
added a commit
that referenced
this pull request
Aug 30, 2022
Without an explicit size, some platforms render bitmap-based cues as 0x0. This effect was seen in Chrome on Mac in particular. This started with PR #4412, where we factored out regions into their own element. The TTML spec says that background images should fill their associated region, so this fixes the issue by making the div explicitly the size of its parent element (100% x 100%).
avelad
pushed a commit
that referenced
this pull request
Aug 31, 2022
Without an explicit size, some platforms render bitmap-based cues as 0x0. This effect was seen in Chrome on Mac in particular. This started with PR #4412, where we factored out regions into their own element. The TTML spec says that background images should fill their associated region, so this fixes the issue by making the div explicitly the size of its parent element (100% x 100%).
avelad
pushed a commit
that referenced
this pull request
Aug 31, 2022
Without an explicit size, some platforms render bitmap-based cues as 0x0. This effect was seen in Chrome on Mac in particular. This started with PR #4412, where we factored out regions into their own element. The TTML spec says that background images should fill their associated region, so this fixes the issue by making the div explicitly the size of its parent element (100% x 100%).
avelad
pushed a commit
that referenced
this pull request
Aug 31, 2022
Without an explicit size, some platforms render bitmap-based cues as 0x0. This effect was seen in Chrome on Mac in particular. This started with PR #4412, where we factored out regions into their own element. The TTML spec says that background images should fill their associated region, so this fixes the issue by making the div explicitly the size of its parent element (100% x 100%).
avelad
pushed a commit
that referenced
this pull request
Aug 31, 2022
Without an explicit size, some platforms render bitmap-based cues as 0x0. This effect was seen in Chrome on Mac in particular. This started with PR #4412, where we factored out regions into their own element. The TTML spec says that background images should fill their associated region, so this fixes the issue by making the div explicitly the size of its parent element (100% x 100%).
This was referenced Nov 6, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both TTML and VTT regions should be thought of as separate elements
from the cue structures they contain. To this end, the UI text
displayer now creates separate region elements to represent CueRegion
objects, and the Cues attached to them nest inside those region
elements in the DOM.
Closes #4381