-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EBU subtitles regression in 4.1.3 - subtitles lost: not added to region #4680
Comments
I see you're using v4.1.3. Please try the latest release in that branch (v4.1.7) and overall (v4.2.4 as of now, though v4.3.0 will be out later today). (We ask similar questions in the issue template, but you seem to have deleted them. Filling out the issue template saves a lot of time for everyone involved, especially across many timezones.) If you're still seeing the issue in those more recent versions, that would be useful to know. Thanks! |
Sorry, I cloned the similar issue rather than started afresh from the template and lost some stuff. Refreshed now with the template. Confirmed still present in 4.3.0. |
After some time of debugging this, some clues emerging. |
Reinstate previously removed region elements when next caption finds it is not there: Detect the absence and ensure `updateDOM` is true so its reinstated and the next caption can be shown. Closes #4680 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
Reinstate previously removed region elements when next caption finds it is not there: Detect the absence and ensure `updateDOM` is true so its reinstated and the next caption can be shown. Closes #4680 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
Reinstate previously removed region elements when next caption finds it is not there: Detect the absence and ensure `updateDOM` is true so its reinstated and the next caption can be shown. Closes #4680 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
Reinstate previously removed region elements when next caption finds it is not there: Detect the absence and ensure `updateDOM` is true so its reinstated and the next caption can be shown. Closes #4680 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
Reinstate previously removed region elements when next caption finds it is not there: Detect the absence and ensure `updateDOM` is true so its reinstated and the next caption can be shown. Closes #4680 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
Reinstate previously removed region elements when next caption finds it is not there: Detect the absence and ensure `updateDOM` is true so its reinstated and the next caption can be shown. Closes #4680 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
Have you read the FAQ and checked for duplicate open issues?
Yes
What link can we use to reproduce this?
https://shaka-player-demo.appspot.com/demo/#audiolang=en;textlang=en;uilang=en;asset=https://otvplayer.nagra.com/vod/dash/clear/bbc/bbc_ebu-tt-d_subtitle_fragmented/dash/ondemand/elephants_dream/1/client_manifest-all-minus-1080p.mpd;panel=CUSTOM%20CONTENT;build=uncompiled
What version of Shaka Player are you using?
v4.3.0-uncompiled
and all the way back to v4.1.3-uncompiled
What browser and OS are you using?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36
What did you do?
What did you expect to happen?
See the captions as follows:
You have to learn to listen.
then
This is not some game.
i.e. from the following TTML snippet.
What actually happened?
Neither of these were shown, nothing was in this time range.
Note: this can only be reprod by playing the stream through this range uninterrupted, if you pause in that region, they can be shown without issue.
Note: I believe this was introduced in #4412
Note the coincidental relationship with #4631 on the same stream and same release.
The text was updated successfully, but these errors were encountered: