fix(subs): Avoid removing in-use region elements #4724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they could be imminently in use
david-hm-morgan
changed the title
david-hm-morgan
changed the title
|
Incremental code coverage: 100.00% |
avelad
added
type: bug
joeyparrish
changed the title
joeyparrish
changed the title
joeyparrish
requested changes
Nov 17, 2022
| @@ -280,7 +280,10 @@ shaka.text.UITextDisplayer = class { | |||
| for (const element of toUproot) { | |||
| // NOTE: Because we uproot shared region elements, too, we might hit an | |||
| // element here that has no parent because we've already processed it. | |||
| if (element.parentElement) { | |||
| // But avoid removing regions here due to risk of missing out | |||
There was a problem hiding this comment.
Your change makes the NOTE comment above false.
|
alternative solution proposed with #4733 |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix: Closes #4680
Avoid removing region elements from the DOM due to risk of failing to put them back with imminent captions in the same region.