Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After each sync the page "http://shanalikhan.github.io/2017/02/19/Option-to-ignore-settings-folders-code-settings-sync.html" is opened #839

Closed
cspwizard opened this issue Apr 10, 2019 · 27 comments

Comments

@cspwizard
Copy link

🐛 Describe the bug
A clear and concise description of what the bug is. You are always welcome to check the Troubleshooting section before filing the ticket.

🌴 Visual Studio Code Version : [ 1.33 ]
🌴 Code Settings Sync Version : [ 3.2.8 ]
🌴 Standard or Insiders : [ standard ]
🌴 OSS or Portable : [ oss ]
🌴 Operating System : [ Ubuntu 18.10 ]
🌴 Occurs On: [Upload / Download]
🌴 Proxy Enabled: [ No ]
🌴 Gist Id: [ ID_HERE ]

📰 To Reproduce
Steps to reproduce the behavior:

  1. Autoupload is triggered
  2. It uploads the settings
  3. http://shanalikhan.github.io/2017/02/19/Option-to-ignore-settings-folders-code-settings-sync.html page gets opened

💪 Expected behavior

  1. Autoupload is triggered
  2. It uploads the settings
    And nothing else happen, current behavior is very annoying

📺 Console Error Log
No errors in the log

@shanalikhan
Copy link
Owner

@arnohovhannisyan can you look into this ?

@cspwizard can you post the following things:

  1. custom settings .json file inside User folder. You can remove the token in that file before posting.
  2. Console Log ( Help Menu > Toogle Developer Tools )

@cspwizard
Copy link
Author

Sure!

settings .json

{ "ignoreUploadFiles": [ "projects.json", "projects_cache_vscode.json", "projects_cache_git.json", "projects_cache_svn.json", "gpm_projects.json", "gpm-recentItems.json", "state.vscdb", "state.vscdb.backup", "syncLocalSettings.json", ".DS_Store", "sync.lock" ], "ignoreUploadFolders": [ "workspaceStorage" ], "ignoreExtensions": [], "gistDescription": "Visual Studio Code Settings Sync Gist", "version": 328, "token": "#", "downloadPublicGist": false, "supportedFileExtensions": [ "json", "code-snippets" ], "openTokenLink": true, "disableUpdateMessage": false, "lastUpload": "2019-04-10T11:15:21.222Z", "lastDownload": "2019-04-09T19:39:03.266Z", "githubEnterpriseUrl": null, "askGistName": false, "customFiles": {}, "hostName": null, "replaceCodeSettings": {} }

Part of the console log (there are some errors):

ERR EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock': Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' console.ts:134 [Extension Host] Sync: syncLocalSettings.json changed console.ts:134 [Extension Host] Sync: state.vscdb-journal changed console.ts:134 [Extension Host] Sync: state.vscdb changed console.ts:134 [Extension Host] rejected promise not handled within 1 second: Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' t.log @ console.ts:134 console.ts:134 [Extension Host] stack trace: Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' t.log @ console.ts:134 log.ts:173 ERR EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock': Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' console.ts:134 [Extension Host] Sync: syncLocalSettings.json changed console.ts:134 [Extension Host] Sync: state.vscdb-journal changed console.ts:134 [Extension Host] Sync: state.vscdb changed console.ts:134 [Extension Host] rejected promise not handled within 1 second: Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' t.log @ console.ts:134 console.ts:134 [Extension Host] stack trace: Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' t.log @ console.ts:134 log.ts:173 ERR EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock': Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' console.ts:134 [Extension Host] Sync: syncLocalSettings.json changed console.ts:134 [Extension Host] Sync: state.vscdb-journal changed console.ts:134 [Extension Host] Sync: state.vscdb changed console.ts:134 [Extension Host] rejected promise not handled within 1 second: Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' t.log @ console.ts:134 console.ts:134 [Extension Host] stack trace: Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' t.log @ console.ts:134 log.ts:173 ERR EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock': Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' console.ts:134 [Extension Host] Sync: syncLocalSettings.json changed console.ts:134 [Extension Host] Sync: state.vscdb changed console.ts:134 [Extension Host] rejected promise not handled within 1 second: Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' t.log @ console.ts:134 console.ts:134 [Extension Host] stack trace: Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' t.log @ console.ts:134 log.ts:173 ERR EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock': Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' console.ts:134 [Extension Host] Sync: syncLocalSettings.json changed console.ts:134 [Extension Host] Sync: state.vscdb changed console.ts:134 [Extension Host] rejected promise not handled within 1 second: Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' t.log @ console.ts:134 console.ts:134 [Extension Host] stack trace: Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' t.log @ console.ts:134 log.ts:173 ERR EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock': Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' console.ts:134 [Extension Host] Sync: syncLocalSettings.json changed console.ts:134 [Extension Host] SyntaxError: Unexpected end of JSON input at JSON.parse (<anonymous>) at p.<anonymous> (/home/ksp/.vscode/extensions/shan.code-settings-sync-3.2.8/out/extension.js:130:94316) at Generator.next (<anonymous>) at s (/home/ksp/.vscode/extensions/shan.code-settings-sync-3.2.8/out/extension.js:130:91920) t.log @ console.ts:134 notificationsAlerts.ts:40 Sync : Unable to read syncLocalSettings.json. Make sure its Valid JSON. onDidNotificationChange @ notificationsAlerts.ts:40 console.ts:134 [Extension Host] Sync: syncLocalSettings.json changed console.ts:134 [Extension Host] Sync: state.vscdb-journal changed console.ts:134 [Extension Host] Sync: state.vscdb changed console.ts:134 [Extension Host] rejected promise not handled within 1 second: Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' t.log @ console.ts:134 console.ts:134 [Extension Host] stack trace: Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' t.log @ console.ts:134 log.ts:173 ERR EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock': Error: EEXIST: file already exists, open '/home/ksp/.config/Code/User/sync.lock' console.ts:134 [Extension Host] Sync: syncLocalSettings.json changed

@cspwizard
Copy link
Author

Also I've several instances of VSCode running, maybe this could cause issues as well.

@shanalikhan
Copy link
Owner

shanalikhan commented Apr 10, 2019

Thanks.
Did it happens for the first time when you report?
Since then, have you tried restarting the code to see still having problem?

edit : for multiple instance, closing all the instances and then opening them

@cspwizard
Copy link
Author

No. the issue is there for couple days. I've restarted all the instances, and even reboot, but it still happens.

@gnomeria
Copy link

Keeps happening to me too. I'll post some more info later

@auxves
Copy link
Contributor

auxves commented Apr 10, 2019

@cspwizard In your user folder, is there a sync.lock file when vscode is closed?

@cspwizard
Copy link
Author

@arnohovhannisyan no, only globalStorage/, keybindings.json, settings.json, snippets/, syncLocalSettings.json, workspaceStorage/

@auxves
Copy link
Contributor

auxves commented Apr 12, 2019

@cspwizard Can you try this out?
https://cdn.discordapp.com/attachments/549007146868539408/566098906031849483/code-settings-sync-3.2.8.vsix

Edit: also, please add "state.*" to ignoreUploadFiles array in syncLocalSettings.json or just reset settings

@cspwizard
Copy link
Author

I'll check a bit later. Thanks!

@cspwizard
Copy link
Author

@arnohovhannisyan with your vsix package it seems to work fine, thanks!

@shanalikhan
Copy link
Owner

@gnomeria can you use the build created by @arnohovhannisyan and let us know if it worked for you too ?

@shanalikhan shanalikhan added this to the Backlog milestone May 17, 2019
@auxves
Copy link
Contributor

auxves commented Jun 2, 2019

Is anyone here able to test my new changes? I need some confirmation that it works as expected before it can be rolled out into the master branch.

VSIX: https://cdn.discordapp.com/attachments/549007146868539408/584860646177505303/code-settings-sync-3.2.9.vsix

Thanks!

@cspwizard
Copy link
Author

I did, it worked for me.

@shanalikhan shanalikhan modified the milestones: Backlog, v3.3.0 Jun 14, 2019
shanalikhan pushed a commit that referenced this issue Jun 19, 2019
* Support multiple instances

* Completely switch to state

* Update to work properly

* Move setting classes to their own models

* Update service names

* Only auto upload using focused window

* Resolve merge conflicts
shanalikhan pushed a commit that referenced this issue Jun 24, 2019
* Support multiple instances

* Completely switch to state

* Update to work properly

* Move setting classes to their own models

* Update service names

* Only auto upload using focused window

* Resolve merge conflicts
@shanalikhan
Copy link
Owner

Auto upload is improved.

I have released new version of Settings Sync v3.3.0 fixing this issue. Im closing this ticket let me know if u guys run into some problem

shanalikhan pushed a commit that referenced this issue Jul 1, 2019
* Updated to task api 2.0.0 and fixed tests

* Set "extensionKind": "ui" to support remote development #61

Fixes #870. See that issue for details

* Clean up previous commits into one

* #800 #515 #854

* Utilized pragmaUtil Functions for kb.json file

* Typo fix

* Added universalKeybindings setting

* chore(package): update @types/node to version 12.0.0 (#873)

* Cleaned up toggling commented settings (#877)

* Cleaned up toggling commented settings

* Updated to include fix by @ioprotium

* Fix warning with webpack

* Update UI

* Change height to max-height

* Add image locally and move it to the top

* Added documentation for tests in CONTRIBUTING.md (#881)

* fix(package): update fs-extra to version 8.0.0 (#882)

* chore(package): update @types/fs-extra to version 7.0.0 (#885)

* chore(package): update @types/node to version 12.0.1 (#883)

* fix(package): update fs-extra to version 8.0.1 (#884)

* Update UI to fit guidelines

* chore(package): update @types/node to version 12.0.2 (#887)

* Improve UI and functionality

* Match BG of theme and properly contrast text

* Fix issues with themes

* Fix image not showing up with light theme

* Fix issues with contrast

* Fix issue with VS Code's WebView

* Update UI and functionality

* Fix potential issue with light themes

* Fix issues with theme on modal

* Refactor

* Add new (but experimental) localizations (#898)

* chore(package): update clean-webpack-plugin to version 3.0.0 (#899)

*  #891

* Update settings page after a reset

* Improve code

* fix(clean-webpack-plugin): (#901)

clean-webpack-plugin was recently updated, and it had breaking changes.

* chore(package): update @types/node to version 12.0.3 (#897)

* #668

* fix(OSS):

enums.ts
----
Allow for setting os type with less code

environmentPath.ts
----
Find code folder and extensions folder more efficiently
Get OS type more efficiently

settings.ts
----
Ignore all state files

sync.ts
----
Adapt for changes in pluginService

pluginService.ts
----
Use vscode command to install extensions
Clean up code and simplify names

* Install extensions in order

* Comment legacy code instead of deleting it

* Fix extension install

* Fix issue with extensions always being deleted

* Get code path more efficiently

* Make sure to escape spaces in cli path

* Fix issues with portable builds

* Support Windows and certain editions

* Improve method for finding extension folder

* Start using API for installation

* Prepare for new API command

* Get ready for new API command

* Fix issue with installation

* Commit requested changes

* #668

* Format pluginService.ts (#906)

* #668

* Throw error

* Try to fix issues with getting missing

* chore(package): update @types/node to version 12.0.7 (#904)

* chore(package): update @types/node to version 12.0.8 (#908)

* #668

* #668

* #668

* #839

* Support multiple instances

* Completely switch to state

* Update to work properly

* Move setting classes to their own models

* Update service names

* Only auto upload using focused window

* Resolve merge conflicts

* #886

* Resolve locale properly

* Clean constructor

* Use state instead of passing in argument

* Update to be compatible with v3.3.0 changes

* Fix readme

* Fix package.json

* Add new settings

* Increase contrast

* Update

package.nls.*.json
----
Add localizations for setting names and placeholders.

github.oauth.service.ts
----
Handle errors in a more user-facing way
Support GitHub enterprise
Show message to user after success

webview.service.ts
----
Use new localizations for names and placeholders

* Bug fix and upload images

* Add support for commits to master (release notes)

* Fix issue

* Fix another issue with release notes

* Update release note template

* Update release notes

* Don't open gist selection if there aren't any gists

* Allow user to view gist

* Revert accidental change

* Support public gist

* Add css, js, and fonts to repo

* Improve font injection

* Revert accidental change
@ngavu
Copy link

ngavu commented Feb 15, 2020

I still experience this in v3.4.3 of the plugin.

@pchodak
Copy link

pchodak commented Feb 24, 2020

Same problem here (3.4.3)

@jeffvv95
Copy link

Same problem here

@IdrisDose
Copy link

Yeahp got this problem seems to be on MacOS my windows build doesn't do this.

@DavyGuedes
Copy link

Hi,
After installing v3.31 and resetting the extension settings, it worked again

@pwkip
Copy link

pwkip commented Apr 25, 2020

same problem on ubuntu 20.4 latest version of VS code and latest version of the plugin.

edit: I fixed it so i'm unsubscribing from this thread. wish i remember what the problem was. i believe i had to remove some generated files and trying again worked. sorry i don't remember the details.

@pascaljr
Copy link

pascaljr commented Jun 1, 2020

same problem here in Windows 10, lateste version of VS Code and latest version of the plugin

@huhaiqing106
Copy link

Same problem here

1 similar comment
@albertoammar
Copy link

Same problem here

@RaheelJameel
Copy link

RaheelJameel commented Jul 24, 2020

I also got this same problem when installing this extension in a new PC.

Was able to fix this by comparing the syncLocalSettings.json file between my new PC and the old PC where code-settings-sync is working. Both were running version 3.4.3.

So the difference I found was of token field being null in the new PC. So I generated a new Personal access token on Github with Gist permissions only and added that to the token field as a string value.

This fixed the issue and I was able to sync settings.

Don't know why the extension didn't automatically save the token before, as I do remember adding the token in the GUI settings editor.

@Obooman
Copy link

Obooman commented Aug 18, 2020

Same problem here, uninstall and reinstall and relaunch vscode sometimes seems to solve this, but have no idea what is happening.

@ShaggyRobot
Copy link

Same problem, Settings Sync v3.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests