[WIP] - [EXPERIMENTAL] Multiple instance support #847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commons.ts ---- Instantiate autoUploadService with context Return null instead of setting variable to null and returning it lockfile.ts ---- Check if file exists to prevent unnecessary writes and potential issues settings.ts ---- Ignore all state files sync.ts ---- Catch errors with lock file Remove unnecessary code that might cause issues autoUploadService.ts ---- Add unique id for original instance Only allow original instance to auto upload Catch errors with lock file Wait for update settings to finish before unlocking package.json ---- Add @types/lockfile for better autocompletion
|
would it be possible to signal the other instances that there has been an update and to trigger a download on the other instances? |
|
@k1nghat This PR only has to do with auto upload. Downloading is not affected by any of the changes proposed here. |
shanalikhan
changed the title
|
@arnohovhannisyan do you think we can improve further on this PR ? Or should i go ahead and merge it. |
|
@shanalikhan it definitely needs more work. |
What do you suggest, can we include this in release of |
|
@shanalikhan If there are no issues after testing, then yes. |
|
@shanalikhan I'm going to open a new PR with these changes because this one currently has old code from v3.2.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This PR fixes issues with multiple instances running at the same time.
Changes proposed in this pull request:
Fixes: #839
How Has This Been Tested?
I have tested it by installing it and running multiple instances of VS Code. However, I could have missed something, so it needs a lot more testing before even thinking about merging it.
Checklist: