Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webpack build process #934

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Fix webpack build process #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04f2bed
Fix webpack build process
auxves Jul 1, 2019
ca85be2
Only ignore warning from express
auxves Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions configs/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

const path = require("path");
const { CleanWebpackPlugin } = require("clean-webpack-plugin");
const webpack = require("webpack");
const nodeExternals = require("webpack-node-externals");

/** @type WebpackOptions */
const config = {
stats: {
warningsFilter: /Critical dependency: the request of a dependency is an expression/
},
target: "node",
entry: "./src/extension.ts",
output: {
Expand All @@ -33,14 +34,11 @@ const config = {
}
]
},
externals: [
{
vscode: "commonjs vscode",
"vscode-fsevents": "commonjs vscode-fsevents",
"original-fs": "commonjs original-fs"
},
nodeExternals()
],
externals: {
vscode: "commonjs vscode",
"vscode-fsevents": "commonjs vscode-fsevents",
"original-fs": "commonjs original-fs"
},
plugins: [new CleanWebpackPlugin()]
};

Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@
"node-fetch": "^2.5.0",
"recursive-readdir": "^2.2.2",
"temp": "^0.9.0",
"vscode-chokidar": "^1.6.5",
"webpack-node-externals": "^1.7.2"
"vscode-chokidar": "^1.6.5"
}
}