Fix webpack build process

[auxves]

Short description of what this resolves:

This PR fixes issues with modules not being bundled.

Changes proposed in this pull request:

• Stop using webpack-node-externals
• Ignore the warning from express

How Has This Been Tested?

Tested by building and installing extension VSIX file.

Checklist:

• I have read the contribution guidelines.

[shanalikhan]

1. Why are we removing webpack-node-externals ?

Webpack allows you to define externals - modules that should not be bundled. When bundling with Webpack for the backend - you usually don't want to bundle its node_modules dependencies. This library creates an externals function that ignores node_modules when bundling in Webpack.

2. Ignore the warning from express

Is there any alternate way to manually define to ignore the warning.

[auxves]

@shanalikhan

Why are we removing webpack-node-externals ?

That package was added to the PR to prevent the warning from express. However, it also stops webpack from bundling necessary dependencies needed by the extension. This is why that error with fs-extra was happening: because it wasn't bundled with the extension. Dependencies should be put in externals only if they already exist on the target system, like built-in node modules (fs, path, etc) or native modules.

Is there any alternate way to manually define to ignore the warning.

Why do we need an alternative way? According to the docs, stats.warningsFilter is the proper way of doing this.

[shanalikhan]

Okay thanks. I will test more scenarios after creating the package and let you know if there is any error.
Else we will release 3.4.0 in coming days.

[shanalikhan]

I have tested it, it still doesnt working. same error

[auxves]

@shanalikhan After cloning v3.4.0, installing dependencies, building it using vsce package, and installing it on a portable version of VSCode with no data, I got no errors and was presented with the landing page. Can you try doing the same?

[shanalikhan]

1. Using standard vscode in ubuntu
2. installed dependencies
3. build package
4. install on standard vscode
5. Same error.

Do you want me to try to portable version as well ? I dont think the code difference will make any impact

[auxves]

@shanalikhan Have you tried cloning it again before doing those steps?

git clone git@github.com:shanalikhan/code-settings-sync -b v3.4.0

or

git clone https://github.com/shanalikhan/code-settings-sync -b v3.4.0

[shanalikhan]

Found it working, need to create package as root user ( although never build using that ).
Thanks