Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple embeds #194

Closed
wants to merge 12 commits into from
Closed

Support multiple embeds #194

wants to merge 12 commits into from

Commits on Mar 24, 2023

  1. Update flags correctly

    @Dakurei
    Dakurei committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    1f1b221 View commit details
    Browse the repository at this point in the history

  2. Rubocop friendly

    @Dakurei
    Dakurei committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    e6355ba View commit details
    Browse the repository at this point in the history

  3. Fix broken test again to pass all tests

    @Dakurei
    Dakurei committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    8e5008e View commit details
    Browse the repository at this point in the history

  4. Request for show_modal should not be called during a modal_submit

    @Dakurei
    Dakurei committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    497a445 View commit details
    Browse the repository at this point in the history

  5. Fix the call to a modal from a message containing a button 

      In this case, @message contains a Hash instead of a Message, preventing to call the .components method on it. So we instantiate a Message object if it is a Hash.
    @Dakurei
    Dakurei committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    9860798 View commit details
    Browse the repository at this point in the history

  6. Adding the new select components 

      + string_select (old select_menu)
  + user_select
  + role_select
  + mentionable_select
  + channel_select
    @Dakurei
    Dakurei committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    1cde13b View commit details
    Browse the repository at this point in the history

  7. Creation of an example file for new "select" components

    @Dakurei
    Dakurei committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    219c2d2 View commit details
    Browse the repository at this point in the history

  8. Error on variable name in the spec/data/webhook_spec

    @Dakurei
    Dakurei committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    8ca378f View commit details
    Browse the repository at this point in the history

  9. Added an example file to create, edit, delete a Webhook 

      Was used as a debugging tool to see why the Webhook#update test was failing in Ruby 3+
    @Dakurei
    Dakurei committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    81b9691 View commit details
    Browse the repository at this point in the history

  10. Bugfix - Webhook#update method cannot be used in Ruby 3+ 

      + update_webhook(**data) will solve the problem in Ruby 3+
  + The addition of "if data.key?(:channel)" fixes a bug also present in Ruby 2.7
    @Dakurei
    Dakurei committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    0ded518 View commit details
    Browse the repository at this point in the history

  11. Added arguments to match the official API version 

      Currently, it is impossible to access more than the first 1000 bans in the list because of these missing arguments.
  https://discord.com/developers/docs/resources/guild#get-guild-bans
    @Dakurei
    Dakurei committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ce7d5dc View commit details
    Browse the repository at this point in the history

  12. Fix the problem preventing the creation and editing of messages with … 

    …multiple embeds

  Issues shardlab#132
    @Dakurei
    Dakurei committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    a3bec22 View commit details
    Browse the repository at this point in the history