Support multiple embeds #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dakurei
force-pushed
the
support_multiple_embeds
branch
from
fd855b3
to
9f5a9ea
Compare
In this case, @message contains a Hash instead of a Message, preventing to call the .components method on it. So we instantiate a Message object if it is a Hash.
+ string_select (old select_menu) + user_select + role_select + mentionable_select + channel_select
Was used as a debugging tool to see why the Webhook#update test was failing in Ruby 3+
+ update_webhook(**data) will solve the problem in Ruby 3+ + The addition of "if data.key?(:channel)" fixes a bug also present in Ruby 2.7
Currently, it is impossible to access more than the first 1000 bans in the list because of these missing arguments. https://discord.com/developers/docs/resources/guild#get-guild-bans
…multiple embeds Issues shardlab#132
Dakurei
force-pushed
the
support_multiple_embeds
branch
from
9f5a9ea
to
a3bec22
Compare
swarley
reviewed
Mar 24, 2023
| data.delete(:channel) | ||
| update_webhook(data) | ||
| update_webhook(**data) |
There was a problem hiding this comment.
I had noticed that this is a problem that affects Ruby 3+.
Without this, the test suite concerning webhooks does not pass, at least without modifying the test directly
| @@ -14,7 +14,7 @@ def self.from_data(data, bot) | |||
| ActionRow.new(data, bot) | |||
| when Webhooks::View::COMPONENT_TYPES[:button] | |||
| Button.new(data, bot) | |||
| when Webhooks::View::COMPONENT_TYPES[:select_menu] | |||
| when Webhooks::View::COMPONENT_TYPES[:string_select] | |||
There was a problem hiding this comment.
Are we not supporting the other select types?
| end | ||
|
|
||
| # Event for when a user interacts with a select menu component. | ||
| class SelectMenuEvent < ComponentEvent |
There was a problem hiding this comment.
This should not be removed and should be the base for all other select events
| end | ||
| end | ||
|
|
||
| # Event handler for a select menu component. | ||
| class SelectMenuEventHandler < ComponentEventHandler |
There was a problem hiding this comment.
Likewise this should be the base for other select menu event handlers
| @@ -55,7 +55,7 @@ | |||
|
|
|||
| describe '.delete_all_emoji_reactions' do | |||
| let(:message_id) { double('message_id', to_s: 'message_id') } | |||
| let(:emoji) { "\u{1F525}" } | |||
| let(:emoji) { '\u{1F525}' } | |||
|
Closed in favor of #209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the problem preventing the creation and editing of messages with multiple embeds
(Based on PR #193)
Fixed
Fix #132