feat: new selects, bugfixes, voice fix #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case, @message contains a Hash instead of a Message, preventing to call the .components method on it. So we instantiate a Message object if it is a Hash.
+ string_select (old select_menu) + user_select + role_select + mentionable_select + channel_select
Was used as a debugging tool to see why the Webhook#update test was failing in Ruby 3+
+ update_webhook(**data) will solve the problem in Ruby 3+ + The addition of "if data.key?(:channel)" fixes a bug also present in Ruby 2.7
Currently, it is impossible to access more than the first 1000 bans in the list because of these missing arguments. https://discord.com/developers/docs/resources/guild#get-guild-bans
…multiple embeds Issues shardlab#132
While passing the emoji in the request in the same way as it is done in Channel.delete_all_emoji_reactions
swarley
reviewed
Mar 26, 2023
swarley
reviewed
Mar 26, 2023
swarley
reviewed
Mar 26, 2023
| # Add SSRC | ||
| discovery_packet += [@ssrc].pack('N') | ||
|
|
||
| # Add 66 zeroes so the packet is 74 bytes long | ||
| discovery_packet += "\0" * 66 |
There was a problem hiding this comment.
This line would be removed if using the suggestion above
swarley
reviewed
Mar 26, 2023
There was a problem hiding this comment.
Looks good, small notes and I'd like feedback from some other contributors on whether or not they agree with my opinion that the select events should inherit a common base event type. @Daniel-Worrall @PanisSupraOmnia
swarley
approved these changes
Mar 26, 2023
|
Thanks a lot! I really appreciate the effort that went into all these changes. Sorry that it took so long to get around to the review |
Closed
swarley
changed the title
This was referenced Mar 26, 2023
Closed
Closed
|
No worries, I did the best I could, and in the meantime most of my bots were running on a branch of my fork with all these changes. It's easier if it's directly on the real "main" branch, but I was in no hurry personally 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the problem of the change in IP Discovery
(Based on PR #194)
Fixed
Fix #208