Fix for Windows: do not run binaries from CWD #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug on Windows where `Command::new` would also run executables from the current working directory, possibly resulting in accidental runs of programs called `less`.
|
Thanks a lot to @BurntSushi for providing this fix as a re-usable function in This fix has been released in bat v0.18.2 |
rhysd
added a commit
to rhysd/actionlint
that referenced
this pull request
Jul 14, 2021
by using execabs.LookPath instead of exec.LookPath context: sharkdp/bat#1724
5 tasks
|
For future reference, here is the PR that will fix this in the Rust std lib: rust-lang/rust#87704 |
|
I would however note that the std has to be cautious about (potentially) breaking compatibility with prior versions of Rust. This means that even if that PR gets merged, it will still do more than just search |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug on Windows where
Command::newwould also runexecutables from the current working directory, possibly resulting in
accidental runs of programs called
less.closes #1472