-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide BufferedZopfliDeflater and allow user to pass in a custom Deflater #530
Conversation
Configure Mend Bolt for GitHub
Heh, so I guess it's a little late now, but thought I should comment here anyway as I have some concerns with this PR.
@shssoichiro Hoping you see this too. |
If it's particularly problematic I can always revert it back out, although I think it's better if we can fix the issues with it here. Sorry, it's rough trying to keep up with all the changes coming in. Everyone's working too hard 😂 |
Hm, I do think it would be best to back it out for now. It may take some time to work through the concerns, especially if some of the changes need to happen in the zopfli library, and I don't think it should remain like this for the next release. |
…later (shssoichiro#530) * Add .whitesource configuration file * Experimental: allow Zopfli to use any size BufWriter * Allow user to specify the output buffer size as well * Allow user to specify maximum block splits * Reformat and fix warnings * Use deflater on iCCP chunk as well * Bug fix: need to implement Zlib format * Make functions const when possible * Switch to using zopfli::Options in prep for zopfli-rs/zopfli#21 * Switch to using zopfli::Options in prep for zopfli-rs/zopfli#21 * Cargo fmt * Fix compilation * Fix tests * Fix more lints * Fix more lints * Fix compilation more --------- Co-authored-by: mend-bolt-for-github[bot] <42819689+mend-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Chris Hennick <hennickc@amazon.com> Co-authored-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
…stom Deflater (shssoichiro#530)" This reverts commit 2a59419.
No description provided.