Let user specify iterations without improvement #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pr0methean
force-pushed
the
iterations-without-improvement
branch
5 times, most recently
from
6729134 to
cdf7851
Compare
Pr0methean
force-pushed
the
iterations-without-improvement
branch
from
cdf7851 to
11d6fce
Compare
Pr0methean
added a commit
to Pr0methean/oxipng
that referenced
this pull request
Jun 24, 2023
Pr0methean
added a commit
to Pr0methean/oxipng
that referenced
this pull request
Jun 24, 2023
Pr0methean
added a commit
to Pr0methean/oxipng
that referenced
this pull request
Jun 24, 2023
Pr0methean
added a commit
to Pr0methean/oxipng
that referenced
this pull request
Jun 24, 2023
Pr0methean
added a commit
to Pr0methean/oxipng
that referenced
this pull request
Jun 24, 2023
|
Thank you a bunch for this PR, your changes look interesting. Before I give it a closer review, I'd like to know if you were able to prove any of the hypotheses you suggested in #17? |
|
No, I haven't. I'll have a lot of experimenting to do in the future. |
Pr0methean
added a commit
to Pr0methean/OcHd-RustBuild
that referenced
this pull request
Jun 24, 2023
Pr0methean
added a commit
to Pr0methean/oxipng
that referenced
this pull request
Jun 24, 2023
AlexTMjugador
approved these changes
Jun 26, 2023
shssoichiro
added a commit
to shssoichiro/oxipng
that referenced
this pull request
Jul 8, 2023
…later (#530) * Add .whitesource configuration file * Experimental: allow Zopfli to use any size BufWriter * Allow user to specify the output buffer size as well * Allow user to specify maximum block splits * Reformat and fix warnings * Use deflater on iCCP chunk as well * Bug fix: need to implement Zlib format * Make functions const when possible * Switch to using zopfli::Options in prep for zopfli-rs/zopfli#21 * Switch to using zopfli::Options in prep for zopfli-rs/zopfli#21 * Cargo fmt * Fix compilation * Fix tests * Fix more lints * Fix more lints * Fix compilation more --------- Co-authored-by: mend-bolt-for-github[bot] <42819689+mend-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Chris Hennick <hennickc@amazon.com> Co-authored-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Pr0methean
added a commit
to Pr0methean/oxipng
that referenced
this pull request
Dec 1, 2023
…later (shssoichiro#530) * Add .whitesource configuration file * Experimental: allow Zopfli to use any size BufWriter * Allow user to specify the output buffer size as well * Allow user to specify maximum block splits * Reformat and fix warnings * Use deflater on iCCP chunk as well * Bug fix: need to implement Zlib format * Make functions const when possible * Switch to using zopfli::Options in prep for zopfli-rs/zopfli#21 * Switch to using zopfli::Options in prep for zopfli-rs/zopfli#21 * Cargo fmt * Fix compilation * Fix tests * Fix more lints * Fix more lints * Fix compilation more --------- Co-authored-by: mend-bolt-for-github[bot] <42819689+mend-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Chris Hennick <hennickc@amazon.com> Co-authored-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Pr0methean
added a commit
to Pr0methean/oxipng
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two enhancements for situations when small compression improvements are worth a lot of CPU time (including research purposes where a high chance of finding the absolute smallest possible file is desired).
It also skips the unused stats randomization during the final iteration. Dead-code elimination could not have done this, because calling a PRNG mutates its state.