Merge pull request #66 from smartikscomtr/master

Close statements
siddhi-io · Feb 24, 2021 · 3859067 · 3859067
2 parents 9a3c4f9 + da44b88
commit 3859067
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...ain/java/io/siddhi/extension/io/cdc/source/polling/strategies/DefaultPollingStrategy.java b/...ain/java/io/siddhi/extension/io/cdc/source/polling/strategies/DefaultPollingStrategy.java
@@ -107,7 +107,7 @@ public void poll() {
 
     public String getLastReadPollingColumnValue(Connection connection) {
         String selectQuery;
-        PreparedStatement statement;
+        PreparedStatement statement = null;
         ResultSet resultSet = null;
         try {
             if (lastReadPollingColumnValue == null) {
@@ -126,7 +126,7 @@ public String getLastReadPollingColumnValue(Connection connection) {
         } catch (SQLException ex) {
             throw new CDCPollingModeException(buildError("Error in polling for changes on %s.", tableName), ex);
         } finally {
-            CDCPollingUtil.cleanupConnection(resultSet, null, null);
+            CDCPollingUtil.cleanupConnection(resultSet, statement, null);
         }
     }
 
@@ -135,7 +135,7 @@ public boolean printEvent(Connection connection) {
         ResultSetMetaData metadata;
         Map<String, Object> detailsMap;
         String selectQuery;
-        PreparedStatement statement;
+        PreparedStatement statement = null;
         boolean isError = false;
         try {
             selectQuery = getSelectQuery("*", "WHERE " + pollingColumn + " > ?");
@@ -161,7 +161,7 @@ public boolean printEvent(Connection connection) {
             }
             log.error(buildError("Error occurred while processing records in table %s.", tableName), ex);
         } finally {
-            CDCPollingUtil.cleanupConnection(resultSet, null, null);
+            CDCPollingUtil.cleanupConnection(resultSet, statement, null);
             return isError;
         }
     }

diff --git a/...siddhi/extension/io/cdc/source/polling/strategies/WaitOnMissingRecordPollingStrategy.java b/...siddhi/extension/io/cdc/source/polling/strategies/WaitOnMissingRecordPollingStrategy.java
@@ -157,7 +157,7 @@ public void poll() {
                     }
                     log.error(buildError("Error occurred while processing records in table %s.", tableName), e);
                 } finally {
-                    CDCPollingUtil.cleanupConnection(resultSet, null, null);
+                    CDCPollingUtil.cleanupConnection(resultSet, statement, null);
                 }
                 try {
                     if (metrics != null) {