Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close statements #66

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Close statements #66

merged 1 commit into from
Feb 24, 2021

Conversation

muratGG
Copy link

@muratGG muratGG commented Sep 12, 2020

Purpose

As we are using connection pool and not really closing the connection, if we don't close the statement we will exceed the open cursor limit.

Goals

Close statement with resultset.

Approach

Passing the statement to cleanup method.

User stories

Release note

Documentation

This is an internal change, no need to change the documentation.

Training

Certification

N/A

Marketing

Automation tests

Security checks

Samples

Related PRs

Migrations (if applicable)

Test environment

Learning

…, if we don't close the statement we will exceed the open cursor limit. This will fix that.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dnwick dnwick merged commit 3859067 into siddhi-io:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants