fix: make both HDMI ports work on RPi 4 #3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
andrewrynhard
previously approved these changes
Apr 4, 2021
AlekSi
commented
Apr 4, 2021
| @@ -5,8 +5,8 @@ | |||
| package rpi4 | |||
|
|
|||
| import ( | |||
| _ "embed" //nolint:gci | |||
There was a problem hiding this comment.
//nolint:gci is required by the combination of blank import, golang/lint issues (and abandonment) and gci being gci.
|
/rebase |
Closes siderolabs#3414. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
andrewrynhard
approved these changes
Apr 5, 2021
There was a problem hiding this comment.
@AlekSi This is a simple enough change that you can force merge. I don't think you need to rebase.
|
That PR wasn't merged because I wanted to re-test it manually :) And yeah, it does not solve the issue. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3414.
Should be tested manually before merge.
make conformance)make fmt)make lint)make docs)make unit-tests)